-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parity with pages-action for Pages deploy outputs #303
Open
courtney-sims
wants to merge
1
commit into
main
Choose a base branch
from
courtney-sims-enable-outputs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+235
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtney-sims
commented
Oct 18, 2024
courtney-sims
force-pushed
the
courtney-sims-enable-outputs
branch
from
October 18, 2024 21:59
73da4bd
to
f6d8d23
Compare
Maximo-Guk
reviewed
Oct 18, 2024
Maximo-Guk
reviewed
Oct 18, 2024
courtney-sims
force-pushed
the
courtney-sims-enable-outputs
branch
3 times, most recently
from
October 21, 2024 16:53
1d56fe8
to
62ce1c3
Compare
Maximo-Guk
reviewed
Oct 21, 2024
courtney-sims
force-pushed
the
courtney-sims-enable-outputs
branch
from
October 22, 2024 21:02
983a2cd
to
03dd701
Compare
courtney-sims
force-pushed
the
courtney-sims-enable-outputs
branch
from
October 22, 2024 21:05
03dd701
to
ee43009
Compare
Maximo-Guk
approved these changes
Oct 22, 2024
Maximo-Guk
reviewed
Oct 22, 2024
} from "./wranglerArtifactManager"; | ||
|
||
describe("wranglerArtifactsManager", () => { | ||
const mock = require("mock-fs"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably be using an es6
style import here
Maximo-Guk
reviewed
Oct 22, 2024
expect(artifacts).toEqual([ | ||
"./testOutputDir/wrangler-output-2024-10-17_18-48-40_463-2e6e83.json", | ||
]); | ||
mock.restore(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could probably move mock.restore()
in to an afterEach()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables Pages deploys to provide outputs for id, environment, url, and alias, just like they can in pages-action. The current way of getting deploy outputs with Workers is via wrangler output to std out, but this information for Pages was not available in std out.
Because of that, this change adds a new method for getting outputs via wrangler artifacts.
The new outputs look like this in the Actions view.
When an alias is not available in the artifact:
When an alias is available in the artifact:
When we don't get stuff back from the request for artifact: